Part 5: Wrap controllers in scheduling/tenancy pkgs #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
commented
Jul 20, 2022
| @@ -849,18 +850,13 @@ func (s *Server) installWorkloadNamespaceScheduler(ctx context.Context, config * | |||
|
|
|||
| func (s *Server) installSchedulingPlacementController(ctx context.Context, config *rest.Config, server *genericapiserver.GenericAPIServer) error { | |||
| controllerName := "kcp-scheduling-placement-controller" | |||
| config = rest.AddUserAgent(rest.CopyConfig(config), controllerName) | |||
| kubeClusterClient, err := kubernetes.NewClusterForConfig(config) | |||
There was a problem hiding this comment.
kubeClusterClient didn't seem to be used anywhere in this controller.
varshaprasad96
changed the title
46 tasks
|
/test e2e-multiple-runs |
sttts
reviewed
Jul 21, 2022
pkg/reconciler/tenancy/clusterworkspacedeletion/clusterworkspace_deletion_controller.go
Outdated
Show resolved
Hide resolved
sttts
reviewed
Jul 21, 2022
pkg/reconciler/tenancy/clusterworkspacedeletion/clusterworkspace_deletion_controller.go
Outdated
Show resolved
Hide resolved
varshaprasad96
force-pushed
the
wrap-scheduling
branch
from
d243dc1 to
66aaa9e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #