clusterworkspace scheduling: default to assigning to the root shard #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Jul 21, 2022
| // no specific shard was required, | ||
| // we are going to schedule the given ws onto the root shard | ||
| // this step is temporary until working with multi-shard env works | ||
| // until then we need to assign ws to the root shard otherwise all e2e test will break |
There was a problem hiding this comment.
would move the comment down to line 100
sttts
reviewed
Jul 21, 2022
pkg/reconciler/tenancy/clusterworkspace/clusterworkspace_reconcile_scheduling.go
Show resolved
Hide resolved
p0lyn0mial
force-pushed
the
schedule-on-the-root-shard
branch
2 times, most recently
from
5995d79 to
b395d2b
Compare
if no specific shard was required, we are going to schedule the given ws onto the root shard. this step is temporary until working with multi-shard env works, until then we need to assign ws to the root shard otherwise all e2e test will break.
p0lyn0mial
force-pushed
the
schedule-on-the-root-shard
branch
from
b395d2b to
0f39e5e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if no specific shard was required, we are going to schedule the given ws onto the root shard.
this step is temporary until working with multi-shard env works,
until then we need to assign ws to the root shard otherwise all e2e test will break.
Related issue(s)
Fixes #