Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterworkspacetypes: simplify system types #1607

Merged

Conversation

sttts
Copy link
Member

@sttts sttts commented Jul 23, 2022

Towards a generic APIBinding mechanism.

@openshift-ci openshift-ci bot requested review from davidfestal and ncdc July 23, 2022 13:55
@sttts
Copy link
Member Author

sttts commented Jul 23, 2022

/assign @stevekuznetsov

@sttts sttts force-pushed the sttts-cwt-base-type-simplify branch from 71180e9 to bd2ead8 Compare July 23, 2022 14:01
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2022
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 042ca6f into kcp-dev:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants