Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/sync: create service account secret in advance to trigger token creation #1613

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

sttts
Copy link
Member

@sttts sttts commented Jul 25, 2022

Stop the bleeding.

@openshift-ci openshift-ci bot requested review from ncdc and stevekuznetsov July 25, 2022 13:55
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@sttts sttts force-pushed the sttts-syncer-1.24 branch from e17cab4 to 9c9efb7 Compare July 25, 2022 14:43
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@sttts
Copy link
Member Author

sttts commented Jul 25, 2022

/cherry-pick release-0.6

@openshift-cherrypick-robot

@sttts: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit e0b05a6 into kcp-dev:main Jul 25, 2022
@openshift-cherrypick-robot

@sttts: #1613 failed to apply on top of branch "release-0.6":

Applying: cli/sync: create service account secret in advance to trigger token creation
Applying: e2e/framework: clarify syncer fixture
Using index info to reconstruct a base tree...
M	test/e2e/framework/fixture.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/framework/fixture.go
CONFLICT (content): Merge conflict in test/e2e/framework/fixture.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 e2e/framework: clarify syncer fixture
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants