synctarget export controller #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiujian16
force-pushed
the
location-workspace-2
branch
from
9bbf00a to
956d333
Compare
qiujian16
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
qiujian16
force-pushed
the
location-workspace-2
branch
4 times, most recently
from
07b4d47 to
2e8c6ec
Compare
openshift-ci
bot
added
the
kind/api-change
sttts
reviewed
Jul 29, 2022
sttts
reviewed
Jul 29, 2022
| continue | ||
| } | ||
|
|
||
| _, err := schemacompat.EnsureStructuralSchemaCompatibility( |
There was a problem hiding this comment.
am unsure we really want this reconciler today. We will rework this API import logic with the API management topic. We can keep the reconciler for now, but should be prepared that this area will change quite a bit. If the reconciler makes trouble, wouldn't have a problem to disable it.
sttts
reviewed
Jul 29, 2022
qiujian16
force-pushed
the
location-workspace-2
branch
5 times, most recently
from
c7ab37d to
c5d9f10
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
location-workspace-2
branch
from
c5d9f10 to
6254bf7
Compare
openshift-merge-robot
removed
the
needs-rebase
qiujian16
force-pushed
the
location-workspace-2
branch
3 times, most recently
from
1ff8403 to
d5db458
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
location-workspace-2
branch
from
d5db458 to
5f26447
Compare
qiujian16
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
davidfestal
reviewed
Aug 16, 2022
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Aug 16, 2022
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetexports_reconcile.go
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
location-workspace-2
branch
2 times, most recently
from
0cbe413 to
3ef6a08
Compare
davidfestal
reviewed
Aug 18, 2022
pkg/reconciler/workload/synctargetexports/synctargetexports_reconcile.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetexports_reconcile_test.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctargetcompatible_reconcile_test.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Aug 18, 2022
pkg/reconciler/workload/synctargetexports/synctargetexports_reconcile.go
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
location-workspace-2
branch
from
3ef6a08 to
5facb25
Compare
davidfestal
reviewed
Aug 22, 2022
pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go
Outdated
Show resolved
Hide resolved
also fix review comments Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
location-workspace-2
branch
from
5facb25 to
468ab1f
Compare
davidfestal
approved these changes
Aug 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
This is to allow user specify the apiexport in another workspace on the synctarget. The controller will
Related issue(s)
Fixes #