Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable avoiding using podman #1628

Conversation

davidfestal
Copy link
Member

Summary

Allow using the CreateKindClusters.sh script without podman, even though podman is installed on the system (for example on linux boxes where you have both docker and podman)

Signed-off-by: David Festal <dfestal@redhat.com>
@openshift-ci openshift-ci bot requested review from ncdc and sttts July 27, 2022 14:27
@davidfestal davidfestal removed the request for review from ncdc July 27, 2022 14:27
@sttts
Copy link
Member

sttts commented Jul 27, 2022

don't care much about this little chance. Overall, IMO this does not really belong into the repository.

@sttts
Copy link
Member

sttts commented Jul 27, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

@davidfestal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-multiple-runs 0cbcc1a link unknown /test e2e-multiple-runs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Member

sttts commented Jul 28, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 692532e into kcp-dev:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants