Fix flaky informers #1649
Merged
Fix flaky informers #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
force-pushed
the
fix-crd-remove-dead-storage-wildcard-partial-metadata
branch
from
0db6e1b to
f0cb024
Compare
Update Kubernetes to pull in the commit that retains rest storage for wildcard partial metadata CRD requests as long as there is at least 1 CRD for that group-resource still in the system. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
fix-crd-remove-dead-storage-wildcard-partial-metadata
branch
from
f0cb024 to
028fcf4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump Kubernetes to pick up kcp-dev/kubernetes#85. Without this change, in the kcp log file, whenever CRDs are deleted, you'll notice a lot of
Terminating all watchers from cacher *unstructured.Unstructuredmessages. This was happening because whenever a CRD is deleted, the system attempts to delete internalcrdInfo"storage" details for any now-deleted CRDs. Unfortunately, because we have a hack where we create simulated UIDs for wildcard partial metadata CR list/watch requests, these UIDs were getting dropped and the storage for them deleted. This resulted in watches being closed prematurely, and then we'd see a lot oftoo old resource versionlog messages about watch closures.With this fix, I don't see either type of log message any more when running the same set of tests that previously were producing a lot of them.
Related issue(s)
Fixes #