Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Go version in CONTRIBUTING.md doc to 1.18 #1651

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

dseapy
Copy link
Contributor

@dseapy dseapy commented Jul 31, 2022

Summary

  • Updates minimum Go version in CONTRIBUTING.md doc to 1.18
  • Adds Jetbrains IDE files to gitignore

Related issue(s)

Fixes #1650

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

Hi @dseapy. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member

sttts commented Jul 31, 2022

Thank you!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2022
@sttts
Copy link
Member

sttts commented Jul 31, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit ac174c6 into kcp-dev:main Jul 31, 2022
hardys pushed a commit to hardys/kcp that referenced this pull request Sep 6, 2022
This should be consistent with the required version updated previously via kcp-dev#1651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing doc Go version older than version in go.mod
3 participants