runs e2e-sharded with two shards #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
kind/api-change
openshift-merge-robot
added
the
needs-rebase
p0lyn0mial
force-pushed
the
run-e2e-with-two-shards
branch
from
054bae8 to
34c8ec1
Compare
openshift-merge-robot
removed
the
needs-rebase
|
unit tests |
sttts
reviewed
Aug 2, 2022
| shardBaseURL string | ||
| shardExternalURL string | ||
| shardVirtualWorkspaceURL string | ||
| externalAddressProvider func() string |
There was a problem hiding this comment.
can you double check: I think in server.go we have a redirect to some external VW URL, maybe including a flag. When @davidfestal removes the personal workspace support, and with your change here, that will probably be not needed anymore very soon.
p0lyn0mial
force-pushed
the
run-e2e-with-two-shards
branch
from
b3ffe8e to
f7bd046
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #