Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: handle only the k8s export #1748

Conversation

stevekuznetsov
Copy link
Contributor

virtual/syncer: compare values, not pointers

Comparing the interface header is not always correct. Compare the UID
and SchemaIdentityHash to be certain we're doing the right thing.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com


virtual/syncer: only handle the kubernetes export

Signed-off-by: Steve Kuznetsov skuznets@redhat.com


/assign @sttts @ncdc
Fixes #1742

@openshift-ci openshift-ci bot assigned ncdc and sttts Aug 15, 2022
@openshift-ci openshift-ci bot requested review from shawn-hurley and sttts August 15, 2022 17:20
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fix-syncer-reconcile branch from 805becf to 97eb353 Compare August 15, 2022 17:20
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2022
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fix-syncer-reconcile branch from 97eb353 to 86f4993 Compare August 15, 2022 17:30
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fix-syncer-reconcile branch from 86f4993 to 275d694 Compare August 15, 2022 17:38
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fix-syncer-reconcile branch from 275d694 to 7f27108 Compare August 15, 2022 17:39
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor Author

/cherry-pick release-0.7

@openshift-cherrypick-robot

@stevekuznetsov: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 961b9b2 into kcp-dev:main Aug 15, 2022
@openshift-cherrypick-robot

@stevekuznetsov: new pull request created: #1750

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syncer stuck on "the server could not find the requested resource"
5 participants