-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified cmd.Use for kubectl-workspaces #1756
modified cmd.Use for kubectl-workspaces #1756
Conversation
Hi @apoorvajagtap. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
not everything is a subcommand. So I don't think shortening the help text is the right direction. |
Hi @sttts, thanks for the inputs. I've now added use & current as well to the Usage section. Let me know if this fits better or not. Thanks again! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary:
As sub-commands like create/create-context required additional details about workspace, whereas rest of the commands did not. So, the usage section
workspace [create|create-context|<workspace>|..|.|-|~|<root:absolute:workspace>] [flags]
might lead to a confusion as some sub-commands aren't specified. Modified the usage section as below, using the generic keywords:Usage: workspace [command] [flags] workspace [command]
Considered keeping (workspace [command]) for commands like
use
.Let me know, if we should only keep
workspace [command] [flags]
instead of both the statements.Fixes #1579