Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/authorization: add audit logging #1833

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

s-urbaniak
Copy link
Contributor

Summary

This adds audit logs for remaining authorizers.

Related issue(s)

Fixes #1307

@openshift-ci openshift-ci bot requested review from ncdc and sttts August 25, 2022 14:07
@s-urbaniak s-urbaniak force-pushed the audit branch 3 times, most recently from 59d167d to 4120653 Compare August 25, 2022 14:38
@s-urbaniak s-urbaniak changed the title pkg/authorization: add audit logging WIP: pkg/authorization: add audit logging Aug 25, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022
@s-urbaniak
Copy link
Contributor Author

/assign s-urbaniak

@s-urbaniak s-urbaniak changed the title WIP: pkg/authorization: add audit logging pkg/authorization: add audit logging Aug 26, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2022
@ncdc
Copy link
Member

ncdc commented Aug 31, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6833c4c into kcp-dev:main Aug 31, 2022
@s-urbaniak s-urbaniak deleted the audit branch August 31, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance audit logging, especially for authorization
4 participants