home-ws: wait for tenancy binding readiness #1872
Conversation
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
| @@ -351,6 +378,21 @@ func (h *homeWorkspaceHandler) ServeHTTP(rw http.ResponseWriter, req *http.Reque | |||
| http.Error(rw, "Creating the home workspace", http.StatusTooManyRequests) | |||
| return | |||
| } | |||
|
|
|||
| if requestInfo.IsResourceRequest && requestInfo.APIGroup == tenancyv1alpha1.SchemeGroupVersion.Group && requestInfo.Resource == "clusterworkspaces" { | |||
There was a problem hiding this comment.
This kind of breaks my brain - can we close over this in searchForWorkspaceAndRBACInLocalInformers? Otherwise the flow here is pretty hard to follow (and we need to discern specifics about what might or might be true based on what some other helper returned)
There was a problem hiding this comment.
I don't have the requestInfo in searchForWorkspaceAndRBACInLocalInformers and it would be a huge amount of work to fix all the test cases that would be broken by adding a param to that function. That's why I did it here.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Summary
If the incoming request is in the home workspaces hierarchy and it's for
clusterworkspaces, there is a chance the tenancy APIBinding is not yet ready (or the cache is stale). If that is the case, return a retry-after to give the APIBinding cache achance to catch up.
Related issue(s)
Fixes #1693