KCP: stop messing with the RawPath #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coded. The Path always fully expands the URL. Since we trim the Path, naturally we would like also to trim the RawPath. To do that correctly we would have to consider encoded slash char as well (%2F). For example the code breaks on %2Fclusters%2F*/apis/apis.kcp.dev/v1alpha1/apiexports Because we don't really need to deal with encoded chars and we don't use the RawPath only the Path we could simplify. This PR simply recomputes the URL after trimming and overwrites it in the HTTP requests.
|
/assign @stevekuznetsov @sttts |
p0lyn0mial
commented
Sep 2, 2022
| newURL, err := url.Parse(req.URL.String()) | ||
| if err != nil { | ||
| responsewriters.ErrorNegotiated( | ||
| apierrors.NewInternalError(fmt.Errorf("unable to resolve %s, err %w", req.URL.Path, err)), |
There was a problem hiding this comment.
it is InternalError because it is on us. Not sure if we want to expose all the details to an end user.
p0lyn0mial
commented
Sep 2, 2022
| return | ||
| } | ||
| req.URL.RawPath = req.URL.RawPath[slash:] | ||
| newURL, err := url.Parse(req.URL.String()) |
There was a problem hiding this comment.
since we don't really use the RawPath we could simply overwrite the Path and leave the RawPath untouched.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, the RawPath is only available when some chars have been encoded. The Path always fully expands the URL.
Since we trim the Path, naturally we would like also to trim the RawPath. To do that correctly we would have to consider encoded slash char as well (%2F).
For example the code breaks on %2Fclusters%2F*/apis/apis.kcp.dev/v1alpha1/apiexports
Because we don't really need to deal with encoded chars and we don't use the RawPath only the Path we could simplify.
This PR simply recomputes the URL after trimming and overwrites it in the HTTP requests.
Summary
Related issue(s)
Fixes #