Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctrl-c not gracefully terminating #1900

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Sep 6, 2022

Summary

Fix ctrl-c not gracefully terminating 'kcp start' by bumping kube to
pull in the backport of the upstream fix that makes it so the audit
backend does not block graceful shutdown of the kcp server.

Related issue(s)

kcp-dev/kubernetes#99

Fix ctrl-c not gracefully terminating 'kcp start' by bumping kube to
pull in the backport of the upstream fix that makes it so the audit
backend does not block graceful shutdown of the kcp server.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@ncdc
Copy link
Member Author

ncdc commented Sep 6, 2022

/cherry-pick release-0.8

@openshift-cherrypick-robot

@ncdc: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ncdc: new pull request created: #1903

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants