🐛 Fix bugs in the resource controller #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs better commit message. Are these two changes or one? |
|
or three? :) |
davidfestal
force-pushed
the
fix-resource-controller
branch
from
64572d6 to
fdf9025
Compare
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
fix-resource-controller
branch
from
fdf9025 to
0279660
Compare
davidfestal
force-pushed
the
fix-resource-controller
branch
from
0279660 to
08a9dde
Compare
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
fix-resource-controller
branch
from
08a9dde to
70bd648
Compare
sttts
reviewed
Oct 5, 2022
sttts
reviewed
Oct 5, 2022
|
Some nits about better go docs. Don't document the obvious. Document more high level what the loops do instead of every line. /lgtm |
openshift-ci
bot
added
lgtm
davidfestal
force-pushed
the
fix-resource-controller
branch
from
70bd648 to
8075087
Compare
sttts
reviewed
Oct 5, 2022
sttts
reviewed
Oct 5, 2022
davidfestal
force-pushed
the
fix-resource-controller
branch
from
8075087 to
6c92e5f
Compare
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
fix-resource-controller
branch
from
6c92e5f to
98f149d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@davidfestal is there any thing for QE to validate here ? Any user facing change or functionality impact that we need to look at ? thanks !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Festal dfestal@redhat.com
Summary
This PR fixes several bugs in the resource controller:
RequestStatelabel to Sync for aSyncTargetwhen the namespace already has the deletion annotation for thisSyncTarget. It doesn't make sense to start syncing a resource to a SyncTarget while the intent already expressed on the namespace is to delete all resources from thisSyncTargetcomputePlacementfunction.See the individual commits for more information
Related issue(s)
Bugs spotted while debugging the Syncer Virtual Transformations e2e test