🐛 Remove the logical-cluster & sync-target labels from syncer namespace

[apoorvajagtap]

Summary

Removing the following labels from the Namespace yaml definition generated while performing a workload sync operation:

labels:
    workload.kcp.io/logical-cluster: {{.LabelSafeLogicalCluster}}
    workload.kcp.io/sync-target: {{.SyncTarget}}

Fixes #1843

[openshift-ci]

Hi @apoorvajagtap. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ncdc]

I think you can also remove LabelSafeLogicalCluster from templateArgs?

[ncdc]

/ok-to-test
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cliplugins/OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stevekuznetsov]

/lgtm

[kasturinarra]

@kasturinarra please help verify this, thanks !!

[kasturinarra]

@apoorvajagtap i tried to verify the issue by creating a workspace with name "kcp-redhat-appstudio-internal-compute" and then running the command 'kubectl kcp workload sync knarracluster1 --syncer-image ghcr.io/kcp-dev/kcp/syncer:v0.9.1 --output-file=syncer1.yaml', verified that the generated syncer1.yaml does not have logical-cluster and sync-target labels in the namespace section , is that the right way to validate or is there anything else that we should be looking here ? thanks !!

[ncdc]

That's all

[kasturinarra]

/label qe-approved

[openshift-ci]

@kasturinarra: The label(s) qe-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kasturinarra]

Detailed steps followed to verify the bug:

1. Login to the kcp env
2. Go to home workspaces using the command 'kubectl kcp ws'
3. create a workspace with name kcp-redhat-appstudio-internal-compute by running the command 'kubectl ws create kcp-redhat-appstudio-internal-compute'
4. Now run the command to create syncer.yaml file 'kubectl kcp workload sync knarracluster1 --syncer-image ghcr.io/kcp-dev/kcp/syncer:v0.9.1 --output-file=syncer1.yaml'
5. Now check the syncer1.yaml file and make sure that the namespace section does not have any labels called logical-cluster & sync-target.