🌱 Syncer: Complete the move to structural logging #2134
Conversation
davidfestal
force-pushed
the
complete-structural-logging-in-syncer
branch
2 times, most recently
from
9a3c9cb to
25fd06e
Compare
davidfestal
force-pushed
the
complete-structural-logging-in-syncer
branch
5 times, most recently
from
f0f19d8 to
ef0a039
Compare
pkg/server/bootstrap/identity.go
Outdated
| @@ -135,7 +135,7 @@ func wildcardIdentitiesResolver(ids *identities, | |||
| logger := logging.WithObject(logger, &apisv1alpha1.APIExport{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: name, | |||
| Annotations: map[string]string{logging.APIVersionKey: tenancyv1alpha1.RootCluster.String()}, | |||
There was a problem hiding this comment.
Shouldn't this be the logicalcluster key...?
There was a problem hiding this comment.
Oh, I don't know. I just added the string() around it when the key was of Key type. But now it should be removed.
There was a problem hiding this comment.
I removed my change in fact. And let the previous code.
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
complete-structural-logging-in-syncer
branch
from
ef0a039 to
f5a50e8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Complete the move to structural logging in the Syncer.
This has been started in a previous PR, but many places were not finished.