🐛 Create VirtualWorkSpaceURL on first APIBinding #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
nrb
commented
Oct 5, 2022
ncdc
reviewed
Oct 6, 2022
ncdc
reviewed
Oct 6, 2022
ncdc
reviewed
Oct 6, 2022
ncdc
reviewed
Oct 6, 2022
nrb
force-pushed
the
fix-1183
branch
2 times, most recently
from
4210ad7 to
29bdfc7
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
nrb
force-pushed
the
fix-1183
branch
3 times, most recently
from
1c40671 to
3ccb73a
Compare
ncdc
reviewed
Oct 11, 2022
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
|
/retest Possible flake kcp-dev/contrib-tmc#89 |
ncdc
approved these changes
Oct 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
kcp-ci-bot
added
the
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Defer creating an APIExport's first virtualWorkspaceURL until the first APIBinding is created.
Related issue(s)
Fixes #1183