🐛 fix CLI tree not showing bottom leafs

[mjudeikis]

Summary

Tree skips bottom if List returns notFound. Separate bug raised why it returns NotFound with custom Workspace type.
I understand this is not the fix, but more of patch. Root cause if 404 itself.

[mjudeikis@unknown kcp]$ go run ./cmd/kubectl-workspace/ tree
(interface {}) <nil>
(interface {}) <nil>
(interface {}) <nil>
(interface {}) <nil>
(*errors.StatusError)(0xc0008ca780)(the server could not find the requested resource (get clusterworkspaces.tenancy.kcp.dev))
(*errors.StatusError)(0xc0008cac80)(the server could not find the requested resource (get clusterworkspaces.tenancy.kcp.dev))
(interface {}) <nil>
(interface {}) <nil>
(interface {}) <nil>
(interface {}) <nil>
.
└── root
    ├── compute
    ├── faros
    │   └── default
    ├── faros-system
    │   ├── controllers
    │   └── tenants
    └── users

with fix:

[mjudeikis@unknown kcp]$ go run ./cmd/kubectl-workspace/ tree
.
└── root
    ├── compute
    ├── faros
    │   └── default
    │       ├── bob
    │       └── bob1
    ├── faros-system
    │   ├── controllers
    │   └── tenants
    └── users

Related issue(s)

Fixes #

[openshift-ci]

Hi @mjudeikis. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

It's not valid to access results when err != nil. This patch makes that happen when apierrors.IsNotFound(err) == true. Can you move the tree.AddBranch() bits to above this fetch instead?

[mjudeikis]

yes, you right. Rushed solution.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cliplugins/OWNERS [stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment