-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add bind workload cmd #2258
✨ Add bind workload cmd #2258
Conversation
@qiujian16 Do you plan to create a distinct PR for the following part mentioned at the end of the related issue description:
? |
The plan is to include it in this PR. I haven't finished that yet, because I need to create some helper func in e2e test for this bind compute at first to avoid breaking e2e. |
7ba6371
to
d5dac4d
Compare
d5dac4d
to
8b03f40
Compare
8b03f40
to
a944794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to individual review comments, I'm not very comfortable with the
kcp bind workload ...
syntax.
I'd rather have:
kcp bind compute
as initially proposed in the description, or
kcp bind location
a944794
to
71a15f8
Compare
71a15f8
to
abf0d52
Compare
abf0d52
to
980e349
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
5817e73
to
8059d7f
Compare
2d39eab
to
e4a2e46
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
e4a2e46
to
ed851a5
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
Add a
bind compute
command to create placement to use locations in the compute workspacekubectl kcp bind compute <my location workspace>
creates a placement, an apibinding to global kubernetes APIExport and an apibinding to kubernetes APIExport in compute workspace if at least one synctarget supports these APIExports.kubectl kcp bind compute <my location workspace>--apiexports root:ws1:foo.bar
creates a placement, an apibinding to foo.bar APIExport if at least one synctarget supports the APIExports.--location-selectos
and--namespace-selector
is to set placement, selectAll is set if not specified.Related issue(s)
Fixes #2102