Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add authorizer test for static endpoints #2487

Merged
merged 1 commit into from
Jan 5, 2023
Merged

🌱 Add authorizer test for static endpoints #2487

merged 1 commit into from
Jan 5, 2023

Conversation

vincepri
Copy link
Contributor

/healthz /livez /readyz and /version

Signed-off-by: Vince Prignano vince@prigna.com

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from davidfestal and kylape December 13, 2022 21:42
@vincepri
Copy link
Contributor Author

/assign @ncdc @sttts

Not sure if this 100% proves that the endpoints are accessible, although figured I'd add one test in the authorizer package. As we chatted in Slack, it seems that the endpoints should be already accessible given that filters.WithScopeCluster changes the request path

@openshift-ci openshift-ci bot assigned ncdc and sttts Dec 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@ncdc
Copy link
Member

ncdc commented Dec 15, 2022

/override e2e-sharded

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@ncdc: Overrode contexts on behalf of ncdc: e2e-sharded

In response to this:

/override e2e-sharded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncdc
Copy link
Member

ncdc commented Dec 15, 2022

/retest

@vincepri
Copy link
Contributor Author

vincepri commented Jan 4, 2023

/test e2e-shared

/healthz /livez /readyz and /version

Signed-off-by: Vince Prignano <vince@prigna.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@sttts
Copy link
Member

sttts commented Jan 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit c582036 into kcp-dev:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants