Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 pkg/authorization: prevent double audit logs #2511

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

s-urbaniak
Copy link
Contributor

Summary

Currently, double audit log entries are generated because the authorization chain is used multiple times. Examples:

  1. Subject access reviews: kubernetes/pkg/registry/authorization/subjectaccessreview/rest.go
  2. Escalation authorization: kubernetes/pkg/registry/rbac/escalation_check.go
  3. bind authorization: kubernetes/pkg/registry/rbac/escalation_check.go

This prevents it by setting a context in the main handler authorization chain only.

Related issue(s)

Fixes #2500

@s-urbaniak s-urbaniak changed the title 🐛 WIP pkg/authorization: prevent double audit logs 🐛 pkg/authorization: prevent double audit logs Dec 19, 2022
@s-urbaniak
Copy link
Contributor Author

Note: setting WIP to merge after workspace refactoring

@s-urbaniak s-urbaniak changed the title 🐛 pkg/authorization: prevent double audit logs 🐛 WIP pkg/authorization: prevent double audit logs Dec 19, 2022
@s-urbaniak s-urbaniak changed the title 🐛 WIP pkg/authorization: prevent double audit logs 🐛 pkg/authorization: prevent double audit logs Dec 21, 2022
@s-urbaniak
Copy link
Contributor Author

unset WIP, rebased on workspace refactoring

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit fb2af5d into kcp-dev:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 double authorization audit log attempts
3 participants