🌱 Skip upsynced resources in resource scheduling #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
added
the
area/transparent-multi-cluster
davidfestal
force-pushed
the
skip-upsynced-resouces-in-resource-scheduling
branch
2 times, most recently
from
73b6c1d to
9b60665
Compare
sttts
reviewed
Jan 5, 2023
| @@ -47,6 +47,11 @@ func (c *Controller) reconcileResource(ctx context.Context, lclusterName logical | |||
| logger := logging.WithObject(logging.WithReconciler(klog.Background(), ControllerName), obj).WithValues("groupVersionResource", gvr.String(), "logicalCluster", lclusterName.String()) | |||
| logger.V(4).Info("reconciling resource") | |||
|
|
|||
| if isUpSynced(obj.GetLabels()) { | |||
| logger.Info("resource is in Upsync mode; ignoring") | |||
There was a problem hiding this comment.
verbosity at least 3, probably more like 4.
sttts
reviewed
Jan 5, 2023
| @@ -486,6 +486,17 @@ func (c *Controller) enqueueSyncTargetKey(syncTargetKey string) { | |||
| } | |||
| } | |||
|
|
|||
| // isUpSynced returns true if the labels of the resource contain at least | |||
| // one `ResourceState` label with the `Upsync` value. | |||
| func isUpSynced(labels map[string]string) bool { | |||
There was a problem hiding this comment.
as a special helper only used in one stop, please move it into the other file.
davidfestal
force-pushed
the
skip-upsynced-resouces-in-resource-scheduling
branch
from
9b60665 to
a58e4ae
Compare
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
skip-upsynced-resouces-in-resource-scheduling
branch
from
a58e4ae to
e7d5874
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resources upsynced from a downstream cluster, and thus having the
Upsynclabel should not be taken in account by resource scheduling.Related issue(s)
No issue dedicated. Spotted while testing PR #2338