🐛 Fix APIExport virtual workspace API bug #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in the APIExport virtual workspace where the APIDefinitionSet was sometimes calculated incorrectly. When an APIResourceSchema informer event came in, we were supposed to enqueue all APIExports in the same logical cluster, but instead it was accidentally trying to enqueue the APIResourceSchema itself. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
stevekuznetsov
approved these changes
Jan 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sttts
reviewed
Jan 6, 2023
| return | ||
| } | ||
|
|
||
| for _, export := range exports { | ||
| logger.WithValues("apiexport", export.Name).V(2).Info("Queueing APIExport for APIResourceSchema") | ||
| c.enqueueAPIExport(obj, logger.WithValues("reason", "APIResourceSchema change", "apiResourceSchema", name)) | ||
| c.enqueueAPIExport(export, logger.WithValues("reason", "APIResourceSchema change", "apiResourceSchema", name)) |
There was a problem hiding this comment.
Could the input to enqueueAPIExport be typed maybe?
There was a problem hiding this comment.
That could be a good thing too 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug in the APIExport virtual workspace where the APIDefinitionSet was sometimes calculated incorrectly. When an APIResourceSchema informer event came in, we were supposed to enqueue all APIExports in the same logical cluster, but instead it was accidentally trying to enqueue the APIResourceSchema itself.
Related issue(s)
Fixes #2501