🐛 cache: stop reporting an error from a CRD lister on incorrect cluster name #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name since all available CRDs are stored in bootstrap.SystemCRDLogicalCluster and there is only a single registry per a CRD there is no need to filter by the given cluster
p0lyn0mial
force-pushed
the
cache-crdlister-stop-the-bleeding
branch
from
21e02a7 to
af8705f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
since all available CRDs for the cache server are stored in
bootstrap.SystemCRDLogicalClusterand there is only a single registry/instance per a CRD
there is no need to filter by the given cluster
stops printing the following message
"programmer error" err="cluster-unaware crd lister got asked for root cluster"when a request for a resource was made (i.e.:
shards/*/clusters/abc/apis/apis.kcp.io/v1alpha1/apiexports') (https://github.com/kcp-dev/kubernetes/blob/b0ffa0d98215b3ec8a1b00f2f001ad86784be8c6/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go#L299)Related issue(s)
Fixes #