Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 committer: fix equality check in statusless committer #2602

Merged

Conversation

sttts
Copy link
Member

@sttts sttts commented Jan 11, 2023

The old bytes comparison was always false.

@openshift-ci openshift-ci bot requested review from ncdc and stevekuznetsov January 11, 2023 20:59
@sttts sttts force-pushed the sttts-statusless-committer-equal branch from 3801fcc to 4c8fd05 Compare January 11, 2023 21:00
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@ncdc
Copy link
Member

ncdc commented Jan 11, 2023

#2603
/retest

@openshift-merge-robot openshift-merge-robot merged commit 844b2ce into kcp-dev:main Jan 11, 2023
@stevekuznetsov
Copy link
Contributor

Any chance we can share more code between these two?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants