🌱 Simplify heartbeat controller #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
openshift-ci
bot
added
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
This base controller has only one consumer. Why do we have it as separate package? |
|
If I had to guess, we probably kept moving consumers away until we were only left with 1, but never collapsed. I'll do that. |
Update the basecontroller/controller to use the committer package. Signed-off-by: Christopher Sams <csams@redhat.com>
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
basecontroller-committer
branch
from
3f64c4e to
a4ff474
Compare
|
Took this over from Chris (as per Slack conversation). Did some cleanup so this will need 👀 |
ncdc
force-pushed
the
basecontroller-committer
branch
2 times, most recently
from
ca310cd to
966342b
Compare
Remove base controller as it only had 1 user, the heartbeat controller. Simplify the heartbeat controller code and structure. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
basecontroller-committer
branch
from
966342b to
5410996
Compare
stevekuznetsov
approved these changes
Mar 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Signed-off-by: Christopher Sams csams@redhat.com
Related issue(s)
#2635