Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 remove deprecated home workspaces fields, add waiting for unmanaged servers in e2e #2707

Merged
merged 7 commits into from
Feb 1, 2023
Merged

🌱 remove deprecated home workspaces fields, add waiting for unmanaged servers in e2e #2707

merged 7 commits into from
Feb 1, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jan 30, 2023

Summary

  • remove deprecated home workspaces fields
  • add waiting for unmanaged servers in e2e

Can split into separate PRs if desired

@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch from 4c36dff to 650772a Compare January 31, 2023 14:18
@ncdc ncdc mentioned this pull request Jan 31, 2023
Closed
@ncdc
Copy link
Member Author

ncdc commented Jan 31, 2023

Flake #2713
/retest

@ncdc ncdc mentioned this pull request Jan 31, 2023
Closed
@ncdc
Copy link
Member Author

ncdc commented Jan 31, 2023

Flake #2714
/retest

@ncdc
Copy link
Member Author

ncdc commented Jan 31, 2023

#2713 again
/retest

@ncdc
Copy link
Member Author

ncdc commented Jan 31, 2023

Flake #2685
/retest

@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch 2 times, most recently from 80dbf00 to ba30ed8 Compare February 1, 2023 15:29
@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch from ba30ed8 to c743528 Compare February 1, 2023 17:09
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

kcp-dev/contrib-tmc#58
/retest

@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

Most recent failure is because the RBAC needed for maximal permission policy didn't replicate "fast enough" to the cache server. Working on a commit to fix the e2e to use Eventually for this.

ncdc added 5 commits February 1, 2023 13:06
@ncdc
Clean up home workspaces
d77370e 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
e2e: all server types wait for readiness
a9c50f4 
Make both managed and unmanaged kcp servers wait for readiness.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
e2e: support terminating "go run kcp start"
1cfbe44 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
Use sentinel file for e2e readiness
3092dfc 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
Fix TestAPIExportAuthorizers flake.
8db9070 
Have to wrap creating the cowboy (via APIBinding) in an Eventually
because the RBAC for the maximal permission policy may not replicate to
the cache server "fast enough".

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch from c743528 to 8db9070 Compare February 1, 2023 18:06
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 1, 2023
@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch from 06e88c6 to 92f286a Compare February 1, 2023 19:06
ncdc added 2 commits February 1, 2023 14:31
@ncdc
Fix TestAPIExportAuthorizers flake
bc8fb6a 
Wrap verifying service-provider-2-admin is denied access to shadowed
cowboys in an Eventually.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc
apiexportendpointslice: use framework.Eventually
0b403cb 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@ncdc ncdc force-pushed the fix-e2e-kcp-servers branch from 60ac84d to 0b403cb Compare February 1, 2023 19:32
@ncdc
Copy link
Member Author

ncdc commented Feb 1, 2023

/retest

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@stevekuznetsov
Copy link
Contributor 

     apiexportendpointslice_test.go:213: Creating the APIExportEndpointSlice
    apiexportendpointslice_test.go:216: 
        	Error Trace:	apiexportendpointslice_test.go:216
        	Error:      	Received unexpected error:
        	            	apiexportendpointslices.apis.kcp.io "my-slicecnxlq" is forbidden: unable to create APIExportEndpointSlice: no permission to bind to export root:e2e-workspace-wptlj:e2e-workspace-cf7ws:my-export
        	Test:       	TestAPIExportEndpointSliceWithPartitionPrivate

@openshift-merge-robot openshift-merge-robot merged commit 2113c9a into kcp-dev:main Feb 1, 2023
@hardys hardys mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@sttts sttts sttts left review comments

@davidfestal davidfestal Awaiting requested review from davidfestal

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncdc @stevekuznetsov @sttts @openshift-merge-robot