🐛 Show workspace name in kubectl kcp ws tree

[hasheddan]

Summary

With the changing structure of the URL stored in the Workspace spec, we stopped showing the Workspace name in kubectl kcp ws tree. This updates to use the Workspace name and fixes the output when --full is supplied.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Previously:

$ k kcp ws use root
Current workspace is "root".
$ k kcp ws tree
.
└── root
    └── 1bav17fzw1njbiv3
        └── 274dgmgvx0btkooe

$ k kcp ws tree --full
.
└── root
    └── 1bav17fzw1njbiv3
        └── 274dgmgvx0btkooe

$ k kcp ws use test
Current workspace is "root:test" (type root:universal).
$ k kcp ws tree --full
.
└── root:test
    └── 274dgmgvx0btkooe

$ k kcp ws tree
.
└── test
    └── 274dgmgvx0btkooe

$ k kcp ws use test-1
Current workspace is "root:test:test-1" (type root:universal).
$ (kxp) k kcp ws tree
.
└── test-1

$ k kcp ws tree --full
.
└── root:test:test-1

Update:

$ go run ./cmd/kubectl-kcp/ ws use root
Current workspace is "root".
$ go run ./cmd/kubectl-kcp/ ws tree
.
└── root
    └── test
        └── test-1

$ go run ./cmd/kubectl-kcp/ ws tree --full
.
└── root
    └── root:test
        └── root:test:test-1

$ go run ./cmd/kubectl-kcp/ ws use test
Current workspace is "root:test" (type root:universal).
$ go run ./cmd/kubectl-kcp/ ws tree --full
.
└── root:test
    └── root:test:test-1

$ go run ./cmd/kubectl-kcp/ ws tree
.
└── test
    └── test-1

$ go run ./cmd/kubectl-kcp/ ws use test-1
Current workspace is "root:test:test-1" (type root:universal).
$ go run ./cmd/kubectl-kcp/ ws tree 
.
└── test-1

$ go run ./cmd/kubectl-kcp/ ws tree --full
.
└── root:test:test-1

Related issue(s)

Fixes #2681

[ncdc]

Flake #2713

[ncdc]

/retest

[hasheddan]

/retest

[hasheddan]

Rebased and force pushed to see if I could get past the test flake here.

[vincepri]

Would it make sense to show both the friendly name and in parentheses the underlying id?

Example:

$ go run ./cmd/kubectl-kcp/ ws tree
.
└── test
    └── test-1 (274dgmgvx0btkooe)

[hasheddan]

@vincepri that sounds pretty reasonable to me, though perhaps only when --full is supplied?

[hasheddan]

That being said -- I believe all the other ws commands deal in "friendly" names, so it might be slightly out of place here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cliplugins/OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment