Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix typo breaking codegen: crds not stored at the right location #2724

Merged
merged 2 commits into from
Feb 1, 2023
Merged

🐛 Fix typo breaking codegen: crds not stored at the right location #2724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b085a04
Fix typo breaking codegen: crds not stored at the right location
fgiloux Feb 1, 2023
780bc64
Schemas changes missing due to issue in codegen script
fgiloux Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/crds/core.kcp.io_logicalclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
versions:
- additionalPrinterColumns:
- description: The current phase (e.g. Scheduling, Initializing, Ready, Deleting)
jsonPath: .metadata.labels['tenancy\.kcp\.dev/phase']
jsonPath: .status.phase
name: Phase
type: string
- description: URL to access the logical cluster
Expand Down
4 changes: 2 additions & 2 deletions config/root-phase0/apiresourceschema-logicalclusters.core.kcp.io.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apis.kcp.io/v1alpha1
kind: APIResourceSchema
metadata:
creationTimestamp: null
name: v230116-943e458f6.logicalclusters.core.kcp.io
name: v230201-b085a04a.logicalclusters.core.kcp.io
spec:
group: core.kcp.io
names:
Expand All @@ -16,7 +16,7 @@ spec:
versions:
- additionalPrinterColumns:
- description: The current phase (e.g. Scheduling, Initializing, Ready, Deleting)
jsonPath: .metadata.labels['tenancy\.kcp\.dev/phase']
jsonPath: .status.phase
name: Phase
type: string
- description: URL to access the logical cluster
Expand Down
2 changes: 1 addition & 1 deletion hack/update-codegen-crds.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ REPO_ROOT=$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)
rbac:roleName=manager-role \
webhook \
paths="./..." \
output:crd:artifacts:config="${REPO_ROOT}"config/crds
output:crd:artifacts:config="${REPO_ROOT}"/config/crds
)

for CRD in "${REPO_ROOT}"/config/crds/*.yaml; do
Expand Down