🌱 workspace_reconcile_scheduling: allow for skipping a shard with a special annotation during scheduling #2782
Conversation
|
|
||
| // unschedulableAnnotationKey is the annotation key used to indicate that a shard is unschedulable. | ||
| // The annotation is meant to be used by e2e tests that otherwise started a private instance of kcp server. | ||
| unschedulableAnnotationKey = "internal.kcp.io/unschedulable" |
There was a problem hiding this comment.
experimental.core.kcp.io/unschedulable
…cial annotation during scheduling introduces an annotation that can be used to indicate that a shard is unschedulable. The annotation is meant to be used by e2e tests that otherwise started a private instance of kcp server.
p0lyn0mial
force-pushed
the
unschedulable-shards-internal
branch
from
b7f9d2d to
ae152a6
Compare
|
An alternative would have been to amend the e2e framework so that the initial shards have a specific label. The fixture used to create workspaces in e2e tests could then use this label for scheduling when no different configuration is provided. With this approach there would be no API or pseudo-API change. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
We also have e.g. cli invocations. We cannot easily change those. |
|
Seems like we could have just gone for the spec field ... it's an alpha API. There is no real cost to it. Annotation-driven APIs are hard to learn. |
Summary
introduces an annotation that can be used to indicate that a shard is unschedulable. The annotation is meant to be used by e2e tests that otherwise started a private instance of kcp server.
I decided to go with an annotation because it is easier to change/delete than an API field.
Related issue(s)
Fixes #