-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Provide access to physical cluster pod definitions from upstream KCP, relying on upsyncing #2805
Merged
openshift-merge-robot
merged 2 commits into
kcp-dev:main
from
davidfestal:pod-access-demo
Feb 21, 2023
Merged
✨ Provide access to physical cluster pod definitions from upstream KCP, relying on upsyncing #2805
openshift-merge-robot
merged 2 commits into
kcp-dev:main
from
davidfestal:pod-access-demo
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/lgtm |
davidfestal
force-pushed
the
pod-access-demo
branch
from
February 16, 2023 19:01
88276d9
to
aa53a44
Compare
sttts
reviewed
Feb 20, 2023
sttts
reviewed
Feb 20, 2023
davidfestal
force-pushed
the
pod-access-demo
branch
2 times, most recently
from
February 20, 2023 18:05
51758b3
to
1dcd36d
Compare
/lgtm |
Signed-off-by: David Festal <dfestal@redhat.com>
... in the SyncerTunnel e2e test Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
pod-access-demo
branch
from
February 20, 2023 20:22
1dcd36d
to
137c573
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR leverages the Upsyncer to bring POD definitions of synced deployments, at the KCP level.
Related issue(s)
Fixes #1977