Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Provide access to physical cluster pod definitions from upstream KCP, relying on upsyncing #2805

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

davidfestal
Copy link
Member

Summary

This PR leverages the Upsyncer to bring POD definitions of synced deployments, at the KCP level.

Related issue(s)

Fixes #1977

@openshift-ci openshift-ci bot requested review from jmprusi and qiujian16 February 16, 2023 17:51
@davidfestal davidfestal requested a review from sttts February 16, 2023 17:58
@jmprusi
Copy link
Member

jmprusi commented Feb 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
pkg/features/kcp_features.go Outdated Show resolved Hide resolved
@davidfestal davidfestal force-pushed the pod-access-demo branch 2 times, most recently from 51758b3 to 1dcd36d Compare February 20, 2023 18:05
@jmprusi
Copy link
Member

jmprusi commented Feb 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
Signed-off-by: David Festal <dfestal@redhat.com>
... in the SyncerTunnel e2e test

Signed-off-by: David Festal <dfestal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@jmprusi
Copy link
Member

jmprusi commented Feb 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@davidfestal davidfestal added this to the v0.11 milestone Feb 21, 2023
@davidfestal
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9640af1 into kcp-dev:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide access to physical cluster pod definitions from upstream KCP, possibly relying on inverse syncing
4 participants