Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Syncer: also mutate StatefulSets and ReplicaSets #2845

Conversation

davidfestal
Copy link
Member

Summary

  • Also mutate the StatefulSets and the ReplicaSets as it is done for the Deployments
  • Extract the mutators from the SpecSyncer (will make it easier to disable them in alternate syncers)

Related issue(s)

Fixes #2844

@openshift-ci openshift-ci bot requested review from jmprusi and ncdc February 23, 2023 20:42
@davidfestal davidfestal requested a review from jmprusi February 23, 2023 20:42
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal force-pushed the upsync-pods-from-synced-podspecable-resources branch from 8d8aa4b to e26c87b Compare February 23, 2023 21:21
@davidfestal davidfestal requested a review from sttts February 28, 2023 09:21
@jmprusi
Copy link
Member

jmprusi commented Feb 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@davidfestal
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit b844be6 into kcp-dev:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply PodTemplateSpec mutation to all PodSpecable types (at least StatefulSets)
3 participants