Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Make the tunneler shard-aware #2946

Merged
merged 3 commits into from
Apr 17, 2023
Merged

✨ Make the tunneler shard-aware #2946

merged 3 commits into from
Apr 17, 2023

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Apr 4, 2023 •
edited
Loading

Summary

Make the tunneler shard-aware:

  • use global sync target informer on the KCP side
  • create 1 tunneler per shard on the Syncer side.

Based on PR #2675. Only the 3 last commits are part of this PR.

Related issue(s)

Fixes #2943

@openshift-ci openshift-ci bot requested review from jmprusi and qiujian16 April 4, 2023 20:32
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 4, 2023
stevekuznetsov
stevekuznetsov reviewed Apr 4, 2023
View reviewed changes
cmd/virtual-workspaces/options/options.go Outdated Show resolved Hide resolved
sdk/apis/workload/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/reconciler/workload/synctarget/synctarget_reconcile.go Outdated Show resolved Hide resolved
pkg/syncer/syncer.go Outdated Show resolved Hide resolved
pkg/syncer/synctarget/tunneler_reconciler.go Outdated Show resolved Hide resolved
@davidfestal davidfestal changed the title PROOF PR Sharded tunneler WIP PROOF PR Sharded tunneler Apr 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023
@davidfestal davidfestal force-pushed the sharded-tunneler branch 2 times, most recently from 22506f1 to 65634c2 Compare April 5, 2023 20:16
@davidfestal
Copy link
Member Author

/test e2e-sharded

@davidfestal davidfestal force-pushed the sharded-tunneler branch 4 times, most recently from d889809 to 0a9b0a1 Compare April 6, 2023 13:53
@davidfestal davidfestal mentioned this pull request Apr 6, 2023
Closed
@davidfestal davidfestal changed the title WIP PROOF PR Sharded tunneler ✨ WIP PROOF PR Sharded tunneler Apr 6, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@davidfestal davidfestal force-pushed the sharded-tunneler branch 2 times, most recently from 3a91224 to 1f93653 Compare April 6, 2023 14:46
@davidfestal
run multishard syncing tests with kind
874a491 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
make subresource proxy shard-aware
290c102 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal changed the title ✨ WIP PROOF PR Sharded tunneler Make the tunneler shard-aware Apr 6, 2023
@davidfestal
Create one tunneler per shard in the Syncer
76e71dd 
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal changed the title Make the tunneler shard-aware ✨ Make the tunneler shard-aware Apr 6, 2023
@davidfestal
Copy link
Member Author

/test e2e-shared

1 similar comment
@davidfestal
Copy link
Member Author

/test e2e-shared

@jmprusi
Copy link
Member

jmprusi commented Apr 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@davidfestal
Copy link
Member Author

/retest-required

@davidfestal
Copy link
Member Author

@sttts or @ncdc Could you please review: it needs approval from you due to the change to the SyncTarget status to add the TunnelWorkspaces field.

@ncdc
Copy link
Member

ncdc commented Apr 17, 2023

Approving for the API change.
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@davidfestal
Copy link
Member Author

/test e2e-shared

@openshift-merge-robot openshift-merge-robot merged commit 2b383ed into kcp-dev:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@sttts sttts sttts left review comments

@jmprusi jmprusi Awaiting requested review from jmprusi

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@jmprusi jmprusi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create one tunneler per shard in the Syncer
6 participants
@davidfestal @jmprusi @ncdc @sttts @stevekuznetsov @openshift-merge-robot