Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 tenancy: only delete LogicalCluster if needed #2957

Conversation

sttts
Copy link
Member

@sttts sttts commented May 19, 2023

Taken from @ncdc's rebase #2945

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@openshift-ci openshift-ci bot requested review from clubanderson and scheeles May 19, 2023 07:01
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@sttts
Copy link
Member Author

sttts commented Jun 3, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 20aa5f1 into kcp-dev:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants