Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add metrics-viewer 'battery' #3024

Merged
merged 1 commit into from
Oct 18, 2023
Merged

🌱 Add metrics-viewer 'battery' #3024

merged 1 commit into from
Oct 18, 2023

Conversation

mjudeikis
Copy link
Contributor

Summary

While hunting down OOM/go-routine issue found that I needed to setup metrics scrapping. For this I needed service account to access them. Where it is easily done, I found this uslefull for few reasons;

  1. I did it multiple times myself so it kinda got to the place - its need to be in the batteries
  2. When using TILT, it does not have a clear phases approach. It usually - You deploy everything and wait. So I ended up maintaining a separate job just to deploy this into KCP with dependency created:
    KCP -> Job -> Prometheus

Having this tilt case becomes - "While deploying Prometheus, read this secret and configure scraping and removing job out of the picture"

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@mjudeikis
Copy link
Contributor Author

This would make TILT setup so much easier!

@sttts
Copy link
Member

sttts commented Oct 16, 2023

Sgtm.

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis requested a review from sttts October 17, 2023 11:35
embik
embik approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f10bad6af82547fb119d67495cb7b7aac1688397

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@kcp-ci-bot kcp-ci-bot merged commit cf4038c into kcp-dev:main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjudeikis @sttts @kcp-ci-bot @embik