Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Make LogicalCluster claimable #3035

Merged
merged 2 commits into from
Oct 23, 2023
Merged

🌱 Make LogicalCluster claimable #3035

merged 2 commits into from
Oct 23, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Oct 21, 2023 •
edited by embik
Loading

Summary

Attempt to make LogicalCluster native resource so it can be used in claims.

Related issue(s)

Fixes #

Release Notes

Make LogicalCluster claimable resource for deeper level integration ontop of KCP

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 21, 2023
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2023
@mjudeikis mjudeikis marked this pull request as ready for review October 21, 2023 10:52
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2023
@mjudeikis mjudeikis requested a review from sttts October 21, 2023 12:28
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis marked this pull request as draft October 22, 2023 08:43
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2023
@mjudeikis
Copy link
Contributor Author

Not working. Checking

@mjudeikis mjudeikis force-pushed the logical.cluster.claimable branch from 5493237 to 87197dc Compare October 22, 2023 12:25
@kcp-ci-bot kcp-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2023
@mjudeikis mjudeikis marked this pull request as ready for review October 22, 2023 12:26
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2023
@mjudeikis mjudeikis force-pushed the logical.cluster.claimable branch 3 times, most recently from cfbea33 to ef3be07 Compare October 22, 2023 12:51
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

@sttts
Copy link
Member

sttts commented Oct 23, 2023

A nit. Otherwise lgtm.

@sttts
Copy link
Member

sttts commented Oct 23, 2023

/approve
/lgtm
/hold

for the nit.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6473da83498d9b552ec4d6a871667701b92ecb06

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@mjudeikis mjudeikis changed the title 🌱 Make LogicalCLuster claimable 🌱 Make LogicalCluster claimable Oct 23, 2023
@mjudeikis mjudeikis force-pushed the logical.cluster.claimable branch from c52e5d2 to 30141e7 Compare October 23, 2023 14:21
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@kcp-ci-bot kcp-ci-bot requested a review from sttts October 23, 2023 14:21
@mjudeikis mjudeikis force-pushed the logical.cluster.claimable branch from 30141e7 to 17b0a49 Compare October 23, 2023 14:21
@mjudeikis
Copy link
Contributor Author

/hold cancel

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/lgtm

@kcp-ci-bot
Copy link
Contributor

@mjudeikis: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member

sttts commented Oct 23, 2023

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31950ef9822150ee6d906b1425b092b7e0dd233b

@mjudeikis
Copy link
Contributor Author

/retest
different flakes :/

@kcp-ci-bot kcp-ci-bot merged commit 1c2cf92 into kcp-dev:main Oct 23, 2023
4 checks passed
@embik embik mentioned this pull request Nov 13, 2023
Merged
@kcp-ci-bot kcp-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2024
@embik embik removed the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjudeikis @kcp-ci-bot @sttts @embik