Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Set controller rest config timeout to 30secs #3112

Merged
merged 1 commit into from
Apr 17, 2024
Merged

🌱 Set controller rest config timeout to 30secs #3112

merged 1 commit into from
Apr 17, 2024

Conversation

sankar17
Copy link

@sankar17 sankar17 commented Apr 4, 2024

Configure the controller rest config timeout to 30 seconds by default to avoid any client stuck at infinitely.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @sankar17. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2024
@palnabarun
Copy link
Member

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2024
@palnabarun
Copy link
Member

@sankar17 can you please add a release note in the PR description? Check the PR body template for the structure.

sttts
sttts reviewed Apr 6, 2024
View reviewed changes
pkg/server/server.go Outdated
@@ -387,7 +387,8 @@ func (s *Server) Run(ctx context.Context) error {
// TODO: split apart everything after this line, into their own commands, optional launched in this process

controllerConfig := rest.CopyConfig(s.IdentityConfig)

// Setting the default restConfig timeout to 30 seconds to avoid any client is waiting infinitely
controllerConfig.Timeout = time.Second * 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering, we should probably set that much earlier. IdentityConfig comes the loopback config if I am not mistaken. So maybe already the loopback config needs this timeout?

@sankar17 sankar17 force-pushed the set-restconfig-timeout-30s branch from 220c3ee to fcb7529 Compare April 10, 2024 17:26
@sankar17 sankar17 requested a review from sttts April 10, 2024 17:39
@ramramu3433
Copy link

/retest

@embik
Copy link
Member

embik commented Apr 11, 2024 •
edited
Loading

@sankar17 please re-add the release notes block that is in the PR description template and add a meaningful release note. Thanks! (here is the template, for reference)

@msankara
set default LoopbackClientConfig timeout to 30secs
358d945 
Signed-off-by: sankarm <sankarm@vmware.com>
@sankar17 sankar17 force-pushed the set-restconfig-timeout-30s branch from ec591b4 to 358d945 Compare April 16, 2024 10:24
@sttts
Copy link
Member

sttts commented Apr 17, 2024

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: defa1193592ed6ad1a175a5eb0c51e05d41648db

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@sttts sttts added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 17, 2024
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 17, 2024
@kcp-ci-bot kcp-ci-bot merged commit dcd4a44 into kcp-dev:main Apr 17, 2024
15 checks passed
@sttts sttts mentioned this pull request Apr 22, 2024
Merged
@sttts sttts mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sankar17 @kcp-ci-bot @palnabarun @ramramu3433 @embik @sttts @msankara