🐛 admission/webhooks: set kcp.io/cluster annotation on create #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
2ea562c to
c707d7f
Compare
kcp-ci-bot
added
the
release-note
sttts
changed the title
kcp-ci-bot
removed
the
release-note-none
|
/lgtm |
|
LGTM label has been added. Git tree hash: 13a9f6f4e04ea76f89d809f9980102e6db5796d6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
No test logs. /retest |
|
Infra. /retest |
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
c707d7f to
ed83394
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: d40d4496729581d251694cb0dce550e0e8fb79fd
|
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
ed83394 to
31b90ee
Compare
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
31b90ee to
4d27de9
Compare
kcp-ci-bot
added
size/XL
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
4d27de9 to
bf20436
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts
force-pushed
the
sttts-admission-cluster-annotation
branch
from
bf20436 to
d7bf892
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6a467e74a633e5e222eeccccc3c59d987ff0d762
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On webhook admission on create, it is unclear where the object comes from. This PR sets the
kcp.io/clusterannotation on webhook dispatch.Release Notes