Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix impersonation for non-system users #3206

Merged
merged 1 commit into from
Dec 11, 2024
Merged

🐛 Fix impersonation for non-system users #3206

merged 1 commit into from
Dec 11, 2024

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Dec 6, 2024 •
edited by embik
Loading

Summary

This is an attempt to improve impersonation security stance.

Related issue(s)

Fixes #

Release Notes

Fix impersonation for non-system users (https://github.com/kcp-dev/kcp/security/advisories/GHSA-c7xh-gjv4-4jgv)

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Dec 6, 2024
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2024
@mjudeikis mjudeikis marked this pull request as ready for review December 6, 2024 13:58
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch 4 times, most recently from f01699e to ed63f61 Compare December 6, 2024 15:26
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

sttts
sttts reviewed Dec 7, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 7, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 7, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 7, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch from ed63f61 to 92150b0 Compare December 7, 2024 17:23
@mjudeikis
Copy link
Contributor Author

Looks like we doing some impersonation in shared model (not sure yet tests or real). Need to debug "

@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch 2 times, most recently from 85de4ab to 13ef6f0 Compare December 7, 2024 20:43
@mjudeikis
Copy link
Contributor Author

/retest

embik
embik reviewed Dec 9, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
pkg/virtual/apiexport/builder/build.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 9, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 9, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 9, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch 3 times, most recently from 52207c5 to d5a9452 Compare December 10, 2024 17:56
@mjudeikis
Copy link
Contributor Author

/retest

sttts
sttts reviewed Dec 10, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
sttts
sttts reviewed Dec 10, 2024
View reviewed changes
pkg/server/handler.go Outdated Show resolved Hide resolved
@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch from d5a9452 to 62d64f5 Compare December 11, 2024 06:47
@mjudeikis
Fix impersonation for non-system users
eaf6ed0 
Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT>
On-behalf-of: SAP mangirdas.judeikis@sap.com
@mjudeikis mjudeikis force-pushed the mjudeikis/impersonate.fix branch from 62d64f5 to eaf6ed0 Compare December 11, 2024 07:13
@embik
Copy link
Member

embik commented Dec 11, 2024

/retest

flake?

@sttts
Copy link
Member

sttts commented Dec 11, 2024

Looks good to go. Merge the Kube PR and revendor?

Lgtm
Approve.

@mjudeikis
Copy link
Contributor Author

Looks good to go. Merge the Kube PR and revendor?

already done in this pr

embik
embik approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving final approval to @sttts.

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9fa35d90ec33f39a9187973cf030f1c9a7c2566

@sttts
Copy link
Member

sttts commented Dec 11, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@mjudeikis
Copy link
Contributor Author

/cherry-pick release-0.26

@kcp-ci-bot
Copy link
Contributor

@mjudeikis: once the present PR merges, I will cherry-pick it on top of release-0.26 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot merged commit 24ab5d4 into kcp-dev:main Dec 11, 2024
16 checks passed
@kcp-ci-bot
Copy link
Contributor

@mjudeikis: new pull request created: #3214

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot mentioned this pull request Dec 11, 2024
Merged
@embik
Copy link
Member

embik commented Dec 11, 2024

/kind bug

@kcp-ci-bot kcp-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 11, 2024
mjudeikis pushed a commit to kcp-ci-bot/kcp that referenced this pull request Dec 11, 2024
@kcp-ci-bot @mjudeikis
Merge pull request kcp-dev#3206 from mjudeikis/mjudeikis/impersonate.fix
50e8196 
🐛 Fix impersonation for non-system users
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 11, 2024
@GoVulnBot GoVulnBot mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjudeikis @kcp-ci-bot @embik @sttts