UPSTREAM: <carry>: garbage collector monitors syncing

[astefanutti]

Adds the ability to update garbage collector monitors for integrators.

Required for kcp-dev/kcp#2112.

[ncdc]

Are you going to do an AST generator for this?

[astefanutti]

Are you going to do an AST generator for this?

Yes, just preferred that you have a look at kcp-dev/kcp@2e900e7 before going forward.

[astefanutti]

@ncdc I've just added the AST-based generator. Let me know if there is more to do.

[ncdc]

@astefanutti thanks! Could you please create commits in this order?

1. The AST generator by itself
2. The unmodified output of running the generator (compare to commit 94dc4f4)
3. The modifications to the patch file (compare to commit bcfaeb0)

[astefanutti]

@ncdc thanks a lot. I've just re-pushed with commits articulated according to your instructions. Let me know if that doesn't meet your expectations.

[ncdc]

This is great! 1 last request: can you include the clusterName in any/all log messages & errors? See e.g.

kubernetes/pkg/controller/resourcequota/resource_quota_controller_patch.go

Line 99 in 6cfb7d4

klog.V(2).Infof("%s: enqueuing resourcequota %s/%s because the list of available APIs changed", rq.clusterName, quota.Namespace, quota.Name)

where rq.clusterName comes from

kubernetes/pkg/controller/resourcequota/resource_quota_controller.go

Line 126 in 6cfb7d4

clusterName: options.ClusterName,

[astefanutti]

@ncdc I've just re-pushed with an extra commit that adds the cluster name to all log statements and errors.