UPSTREAM: <carry>: apiextensions-apiserver allow for disabling generation repair #132
Conversation
…tion repair Exposes DisableGenerationRepair option that allows for disabling setting a generation during an object decoding (for objects that haven't had it). This field is meant to be set by the cache server so that built-in source objects don't differ from the replicated ones.
p0lyn0mial
force-pushed
the
kcp-apiextension-generation-repair
branch
from
531552f
to
4c8a0f2
Compare
|
What is the priority on this? Can it wait until after I'm done w/the 1.26 rebase? Or do you need it sooner? @davidfestal |
Without this patch the replication controller might be a bit chatty because on each reconciliation some source resources will be always different from the replicated ones (this is true at least for ClusterRoles and ClusterRoleBindings). Ideally if we could merge it sooner than later. Thanks! |
|
@ncdc if we wait for this PR to be merged before PR kcp-dev/kcp#2933 is merged, as suggested by @p0lyn0mial, that would mean that the whole TMC Sharding support work would be delayed. |
|
Ok, please feel free to merge when you're ready and I'll adjust in the rebase. Thanks for the clarification! |
|
OK, we've decided to merge it after the rebase. |
Exposes
DisableGenerationRepairoption that allows for disabling setting a generation during an object decoding (for objects that haven't had it).This field is meant to be set by the cache server so that built-in source objects don't differ from the replicated ones.
Previously replicated objects always had the generation field set even if the source/original object hasn't had this field set (i.e. ClusterRoles).
fixes: kcp-dev/kcp#2935