apiserver/admission-webhooks: make lcluster aware #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to handle validating and mutating webhooks for logical cluster Attempted to keep the changes localized to admission plugin package
sttts
commented
Apr 27, 2022
| @@ -115,9 +113,6 @@ func NewServerRunOptions() *ServerRunOptions { | |||
| // disable the watch cache | |||
| s.Etcd.EnableWatchCache = false | |||
|
|
|||
| // TODO: turn off the admission webhooks for now | |||
| s.Admission.DefaultOffPlugins.Insert(validating.PluginName, mutating.PluginName) | |||
There was a problem hiding this comment.
@shawn-hurley I remove you insert few lines below. Is that correct? Any reason it should be off by default?
There was a problem hiding this comment.
They should be off by default for us because they are not logical cluster-aware. For the generic control plane, I think it could be fine, but we will need to double-check in the KCP pr that this is off.
shawn-hurley
approved these changes
Apr 27, 2022
sttts
force-pushed
the
sttts-add-validation-admission-lcluster-aware
branch
from
228aa3f to
cc7ed2e
Compare
It breaks current kcp main. We will reapply when kcp is updated. This reverts commit bdc8872.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to #52 by @shawn-hurley. I have just simplified it a little to make it less costly on rebases.