Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypresses also register on Files pane immediately after switching files #24

Closed
scriptingtest opened this issue Oct 16, 2024 · 5 comments

Comments

@scriptingtest
Copy link

Describe the bug
Immediately after switching files, the Files pane is simultaneously focused (indicated by highlight).
In this state, keypresses also register as interactions with the Files pane. This becomes problematic when:

  • Typing a filename for a newly created file
  • Editing a Canvas file by selecting cards

To Reproduce
Assuming that TagRoutes release 1.1.4 is enabled in a new Obsidian vault, do either of the following:

  1. Create a new Markdown file
    1. The text cursor should be focused on the filename in the markdown tab.
    2. Do not click anywhere. Type a word or letter, then press Space.
  2. Create a new Canvas file
    1. Double-click the canvas to create a new card.
    2. The text cursor should be focused within the card in the canvas tab.
    3. Do not click anywhere. Type a word or letter, then press Space.
    4. Alternatively, click outside the card. Click once to select the card, then press Delete.

Expected behavior
Space/Delete should not interrupt typing/editing due to also interacting with the Files pane.

Desktop (please complete the following information):

  • OS: Windows 11

Additional context
Add the option to toggle automatic highlighting on the current file in the Files pane.

@kctekn
Copy link
Owner

kctekn commented Oct 16, 2024

Thank you for the feedback! I understand what you described, and I will incorporate this fix in the next release.

@kctekn
Copy link
Owner

kctekn commented Oct 17, 2024

@scriptingtest
Copy link
Author

scriptingtest commented Oct 24, 2024

I can confirm that, with auto-focus enabled, keypresses no longer register in context to the Files pane when creating new files or canvas cards; however, new files cannot be renamed immediately, and new canvas cards are unfocused when created.

Still, the issues no longer occur when performing the steps to reproduce it, so I would consider it technically fixed.

kctekn added a commit that referenced this issue Oct 25, 2024
@kctekn
Copy link
Owner

kctekn commented Oct 25, 2024

I can confirm that, with auto-focus enabled, keypresses no longer register in context to the Files pane when creating new files or canvas cards; however, new files cannot be renamed immediately, and new canvas cards are unfocused when created.

Still, the issues no longer occur when performing the steps to reproduce it, so I would consider it technically fixed.

Thank you for the feedback! I revisited the issue and I believe it's now resolved. I've made the necessary changes and published a pre-release version: v1.1.7.

Could you please test it out and let me know if everything works as expected? If all is good, I'll mark it as the latest release.

Thanks again!

@scriptingtest
Copy link
Author

scriptingtest commented Nov 7, 2024

Late reply--I checked the mentioned version (as the latest release version), and it seems that I can type into the title of new files and canvas cards without any keys also registering for the Files pane. I consider this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants