Misc/055 fix #814
Closed
Misc/055 fix #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUG] There is a random chance that misc/055 would fail with stale qgroups detected. [CAUSE] Commit 82f7d6c ("btrfs-progs: qgroup: handle stale qgroup deletion more accurately") changed the behavior of "btrfs qgroup clear-stale" that it will no longer try to remove qgroup undert deletion. And the test case itself relies on the return value of "btrfs qgroup clear-stale" to do the extra wait for subvolume deletion. This means after that commit, the test case would skip the wait if there is a subvolume waiting for cleanup, result a race window where the subvolume can be dropped and become stale, and eventually trigger the stale qgroup detection and cause false alerts. [FIX] Fix the test case by always wait for the subvolume to be dropped, so that later "btrfs qgroup clear-stale" can properly remove all staled qgroups. Signed-off-by: Qu Wenruo <wqu@suse.com>
kdave
pushed a commit
that referenced
this pull request
Jun 16, 2024
…tale [BUG] There is a random chance that misc/055 would fail with stale qgroups detected. [CAUSE] Commit 82f7d6c ("btrfs-progs: qgroup: handle stale qgroup deletion more accurately") changed the behavior of "btrfs qgroup clear-stale" that it will no longer try to remove qgroup under deletion. And the test case itself relies on the return value of "btrfs qgroup clear-stale" to do the extra wait for subvolume deletion. This means after that commit, the test case would skip the wait if there is a subvolume waiting for cleanup, resulting in a race window where the subvolume can be dropped and become stale, and eventually trigger the stale qgroup detection and cause false alerts. [FIX] Fix the test case by always wait for the subvolume to be dropped, so that later "btrfs qgroup clear-stale" can properly remove all stale qgroups. Pull-request: #814 Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
|
Merged to devel, thanks. |
kdave
pushed a commit
that referenced
this pull request
Jun 17, 2024
…tale [BUG] There is a random chance that misc/055 would fail with stale qgroups detected. [CAUSE] Commit 82f7d6c ("btrfs-progs: qgroup: handle stale qgroup deletion more accurately") changed the behavior of "btrfs qgroup clear-stale" that it will no longer try to remove qgroup under deletion. And the test case itself relies on the return value of "btrfs qgroup clear-stale" to do the extra wait for subvolume deletion. This means after that commit, the test case would skip the wait if there is a subvolume waiting for cleanup, resulting in a race window where the subvolume can be dropped and become stale, and eventually trigger the stale qgroup detection and cause false alerts. [FIX] Fix the test case by always wait for the subvolume to be dropped, so that later "btrfs qgroup clear-stale" can properly remove all stale qgroups. Pull-request: #814 Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
kdave
pushed a commit
that referenced
this pull request
Jun 24, 2024
…tale [BUG] There is a random chance that misc/055 would fail with stale qgroups detected. [CAUSE] Commit 82f7d6c ("btrfs-progs: qgroup: handle stale qgroup deletion more accurately") changed the behavior of "btrfs qgroup clear-stale" that it will no longer try to remove qgroup under deletion. And the test case itself relies on the return value of "btrfs qgroup clear-stale" to do the extra wait for subvolume deletion. This means after that commit, the test case would skip the wait if there is a subvolume waiting for cleanup, resulting in a race window where the subvolume can be dropped and become stale, and eventually trigger the stale qgroup detection and cause false alerts. [FIX] Fix the test case by always wait for the subvolume to be dropped, so that later "btrfs qgroup clear-stale" can properly remove all stale qgroups. Pull-request: #814 Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG]
There is a random chance that misc/055 would fail with stale qgroups
detected.
[CAUSE]
Commit 82f7d6c ("btrfs-progs: qgroup: handle stale qgroup deletion
more accurately") changed the behavior of "btrfs qgroup clear-stale"
that it will no longer try to remove qgroup undert deletion.
And the test case itself relies on the return value of "btrfs qgroup
clear-stale" to do the extra wait for subvolume deletion.
This means after that commit, the test case would skip the wait if there
is a subvolume waiting for cleanup, result a race window where the
subvolume can be dropped and become stale, and eventually trigger the
stale qgroup detection and cause false alerts.
[FIX]
Fix the test case by always wait for the subvolume to be dropped, so
that later "btrfs qgroup clear-stale" can properly remove all staled
qgroups.