Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the annotations expand over the whole width instead of the text wrapping up? #70

Closed
gbstan opened this issue Feb 2, 2021 · 14 comments · Fixed by #111 or #117
Closed

Could the annotations expand over the whole width instead of the text wrapping up? #70

gbstan opened this issue Feb 2, 2021 · 14 comments · Fixed by #111 or #117
Labels
enhancement New feature or request

Comments

@gbstan
Copy link

gbstan commented Feb 2, 2021

I really love this programme. I was wondering if it would be possible to have the annotations in the second panel expand to take advantage of the width available instead of the text wrapping up over several lines irrespective of the size of the terminal?

@gbstan gbstan added the enhancement New feature or request label Feb 2, 2021
@gbstan gbstan changed the title Could the annotation expand over the whole width instead of the text wrapping up? Could the annotations expand over the whole width instead of the text wrapping up? Feb 2, 2021
@kdheepak
Copy link
Owner

kdheepak commented Feb 2, 2021

Probably. The way it is currently is the way taskwarrior presents that information. Can you clarify why you'd want it to be compressed?

@gbstan
Copy link
Author

gbstan commented Feb 16, 2021

I do not want it to be compressed. On the contrary, I would like the annotation text to take advantage of the available terminal window width available.
Currently when using

task task_number

all the annotation text for the task with task number task_number appear using the whole width available in the terminal window.
In taskwarrior-tui, long annotation text is wrapped up over several lines in the second panel that gives details of the task.

@kdheepak
Copy link
Owner

kdheepak commented Feb 16, 2021

Just to clarify, are you talking about annotations of a task or the description of a task?

@kdheepak
Copy link
Owner

On the left is the output of taskwarrior and on the right is the output of taskwarrior-tui:

Screen Shot 2021-02-16 at 4 40 27 AM

I've added an annotation of random letters that was longer than the terminal width. In taskwarrior it wraps around but it taskwarrior-tui it is truncated by the terminal width. Is that what you are talking about?

@gbstan
Copy link
Author

gbstan commented Feb 16, 2021

Yes, this is what I am talking about for the annotations.
What happens for a full screen window terminal on my side is that taskwarrior expands the annotation to the width of the window and wraps the text if it is longer that the width but taskwarrior-tui wraps the text of the annotations at a fixed width irrespective of the window width.

@gbstan
Copy link
Author

gbstan commented Feb 16, 2021

It would be very good if the text in the annotation wraps when it reaches the full width of the terminal or "box" which contains it. This is what taskwarrior does in the terminal window.

@kdheepak
Copy link
Owner

I got it, thanks for the clarification. I'll look into that!

@gbstan
Copy link
Author

gbstan commented Feb 16, 2021 via email

@kdheepak
Copy link
Owner

This feature should be available in this release: https://github.com/kdheepak/taskwarrior-tui/releases/tag/v0.10.4

@gbstan
Copy link
Author

gbstan commented Feb 17, 2021

This is great! Thank you so much for being so responsive. I have tested this a bit more. It is almost there. The only thing is that when resizing the window to smaller sizes, I have noticed that some (one or two) characters are cut from the end of a line to the next one when the text wraps. This might be due to the fact that the border within which the annotation text is enclosed makes the space available for the text a bit less than the actual width of the terminal window. If you could have a look into this to actually not loose some characters at the end of a line when the text wraps (easy to spot when reducing the width of the window) that would be very much appreciated.

@kdheepak
Copy link
Owner

You are right! Nice catch! I'll make a new release with this change shortly :)

@gbstan
Copy link
Author

gbstan commented Mar 1, 2021

I still see the task details missing a couple of characters when the line wraps. Maybe this has already been fixed in a future release?

@kdheepak
Copy link
Owner

kdheepak commented Mar 1, 2021

I meant to make a new release sooner but didn't get to it. It is fixed in the latest master, but I'll be making a new release this week.

@kdheepak
Copy link
Owner

kdheepak commented Mar 1, 2021

I've made a new release that should have a fix for this issue: https://github.com/kdheepak/taskwarrior-tui/releases/tag/v0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants