Implement nanogen configs and cmsDriver support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun
reviewed
Jun 3, 2020
| @@ -987,6 +988,8 @@ def define_Configs(self): | |||
| self.REPACKDefaultSeq='DigiToRawRepack' | |||
| self.PATDefaultSeq='miniAOD' | |||
| self.PATGENDefaultSeq='miniGEN' | |||
| #TODO: Check based of file input | |||
There was a problem hiding this comment.
Hi Kenneth - did you have an idea how to do this? I've been running the GEN and NANOGEN steps independently due to different CMSSW versions, and so had to change this logic for my use case. I see cmsDriverOptions.py has a --inputEventContent argument, but I don't know if requiring that argument is ideal.
There was a problem hiding this comment.
no, I don't think it's possible to have pieces of a config that run in different CMSSW versions. But for GEN it really doesn't matter, I just use the 10_6 or 11_X for everything.
(assuming you're using a gridpack, it doesn't matter at all, and you probably don't care tooooo much about the Pythia version)
There was a problem hiding this comment.
By the way you can see a lot of configs and cmsDriver commands that I've used here:
kdlong
pushed a commit
that referenced
this pull request
Jun 19, 2020
…ms (L1Trigger/TrackFindingTMTT) (cms-sw#29381) * create separate PRs for the two L1TK packages * Improved KF efficiency at high eta * Moved MC data files to cms-data * Removed old file * Removed KF HLS to put instead in external library * Ran scram b code-format * Delete KF4ParamsComb.h.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.h.bak * Delete KF4ParamsComb.cc.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.cc.bak * L1 tk integration tmtt pre5 (#7) * Added CMS code style fixes * Removed old file * Reapplied stub b code-format * All code review changes (#13) * Fix clang errors (#14) * fixed clang error * directory for MC txt files * Fixed clang warnings + minor simplifications (#15) * tweak * tweak * Fixed clang warnings and small simplifications * Fixed clang warnings and small simplifications * All remaining review comments addressed (#16) * Replaced vector size with empty function * Simplified DegradeBend and StubWindowSuggest * Fixed more review comments * More review comments * code reformat * Ran exhaustive clang tidy * Added library to BuildFile.xml (#17) * Deleted TrackFindingTMT/data/README (#18) * Added library to BuildFile.xml (This was already done yesterday. Not sure why it appears again) * README file in data directory deleted * Fix review comments (#20) Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
kdlong
added a commit
that referenced
this pull request
Feb 21, 2022
Add params needed for muon corrections
kdlong
pushed a commit
that referenced
this pull request
Jun 17, 2022
Code maintenance for Run III in the DQMOffline ZCounting.
kdlong
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.