Very basic UI for Upstream Sync with Content Library Blocks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdmccormick FYI. Also: nice work on your PR! You have the data available so nicely, it was trivial to implement this first stab at the UI. |
|
@rpenido FYI |
bradenmacdonald
force-pushed
the
braden/sync-icons
branch
from
9bb8138
to
6dffc60
Compare
kdmccormick
force-pushed
the
kdmccormick/upstream-proto
branch
4 times, most recently
from
d91bd1e
to
1f8e0b0
Compare
|
I have updated the icons to the ones specified in openedx/frontend-app-authoring#1335 |
bradenmacdonald
force-pushed
the
braden/sync-icons
branch
from
12106ea
to
12952c5
Compare
kdmccormick
force-pushed
the
kdmccormick/upstream-proto
branch
5 times, most recently
from
0fec922
to
8de8b45
Compare
kdmccormick
force-pushed
the
kdmccormick/upstream-proto
branch
from
8de8b45
to
4eab85e
Compare
bradenmacdonald
force-pushed
the
braden/sync-icons
branch
from
12952c5
to
7ef9cad
Compare
kdmccormick
force-pushed
the
kdmccormick/upstream-proto
branch
from
4eab85e
to
5179a8f
Compare
|
Manually merged into openedx#34925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements openedx/frontend-app-authoring#1338 and part of openedx/frontend-app-authoring#1341 . Depends on openedx#34925 .
This PR displays an icon when content comes from a content library (see on the left):
Or if the link is broken, it says that:
And when an update is available, it displays a working "Update" button
It does not yet have a modal to allow you to accept/reject/preview the changes. This is just a developer tool at the moment.
Note: these icons are temporary - I'm waiting to get the correct icons as SVG.
Testing instructions
link_to_upstream=True,Deadline
ASAP - before Sumac.