Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhaul Dockerfile for improved developer workflow #17

Closed
wants to merge 2 commits into from

Commits on Oct 3, 2022

  1. fix: installation of local requirements

    The `compilejsi18n` command was failing during image building because the
    Open-edX package was not installed properly. The reason for that was an earlier
    change where we got rid of the `pip install -r requirements/edx/local.in`
    command. Installing the Open-edX package was part of this requirement file.
    
    The local.in requirements file no longer exists, but we still need to `pip
    install -e .` the edx-platform repo. To run this command we need both the
    edx-platform repo and the virtualenv.
    
    The good news is that there are no more local requirements in the base.txt
    requirements file. This means that we no longer have to COPY the edx-platform
    repo in the requirements installation step. Thus, changes in edx-platform will
    no longer trigger a rebuild of the pip requirements; this means that re-builds
    will be much faster when making changes to edx-platform.
    
    Note that plugins that implemented the
    "openedx-dockerfile-post-python-requirements" patch and that needed access to
    the edx-platform repo will no longer work. Instead, these plugins should
    implement the "openedx-dockerfile-pre-assets" patch. This scenario should be
    very rare, though.
    
    Close overhangio#726
    regisb committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    49ce8b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63ed3b1 View commit details
    Browse the repository at this point in the history